Skip to content

wails: do not overwrite user provided tools#497974

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:wails-not-override-tools
Mar 10, 2026
Merged

wails: do not overwrite user provided tools#497974
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:wails-not-override-tools

Conversation

@SuperSandro2000
Copy link
Member

For example when building a project with golang 1.26 we want to use the user provoided compiler and not have to run wailts like:
GOTOOLCHAIN=go1.26.0 wails build -compiler '${go_1_26}/bin/go'

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

For example when building a project with golang 1.26 we want to use the
user provoided compiler and not have to run wailts like:
  GOTOOLCHAIN=go1.26.0 wails build -compiler '${go_1_26}/bin/go'
@SuperSandro2000 SuperSandro2000 mentioned this pull request Mar 8, 2026
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Mar 8, 2026
@nixpkgs-ci nixpkgs-ci bot requested a review from thtrf March 8, 2026 18:11
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Mar 8, 2026
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 497974
Commit: 8932d2d9bff2af155a3c9ed5c91fae6013ec87be (subsequent changes)
Merge: 87d275f40ab60a02c65d315b2c7916d138603aeb

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/22826905646


x86_64-linux

✅ 3 packages built:
  • satisfactorymodmanager
  • tiny-rdm
  • wails

aarch64-linux

✅ 3 packages built:
  • satisfactorymodmanager
  • tiny-rdm
  • wails

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • wails

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 8, 2026
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Mar 10, 2026
Merged via the queue into NixOS:master with commit ca7087c Mar 10, 2026
34 of 36 checks passed
@SuperSandro2000 SuperSandro2000 deleted the wails-not-override-tools branch March 10, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants