spotiflac: init at 7.1.0 by Superredstone · Pull Request #486412 · NixOS/nixpkgs

Superredstone · 2026-02-02T23:18:24Z

Things done

Henry-Hiles · 2026-02-05T09:37:27Z

There should be two commits only. The first will be adding you as a maintainer, the second adding the package.

Superredstone · 2026-02-05T09:51:59Z

There should be two commits only. The first will be adding you as a maintainer, the second adding the package.

Should I delete the pr and make a new one?

Henry-Hiles · 2026-02-05T10:45:51Z

There should be two commits only. The first will be adding you as a maintainer, the second adding the package.

Should I delete the pr and make a new one?

No, just rebase or change history another way and force push.

Superredstone · 2026-02-05T13:49:09Z

There should be two commits only. The first will be adding you as a maintainer, the second adding the package.

Should I delete the pr and make a new one?

No, just rebase or change history another way and force push.

I squashed six commits into two. Did I do it correctly?

Henry-Hiles · 2026-02-05T20:40:47Z

Close, but your package init commit should say "init at" like the title of the PR does.

Superredstone · 2026-02-05T20:53:34Z

Fixed

pkgs/by-name/sp/spotiflac/package.nix

Bot-wxt1221 · 2026-02-06T13:52:35Z

pkgs/by-name/sp/spotiflac/package.nix

+
+  overrideModAttrs = {
+    preBuild = ''
+      wails build -tags webkit2_41 -o spotiflac


Could we avoid two time built?

I was wondering for two days straight why the build process started two times

EDIT: typo

Henry-Hiles

LGTM

Bot-wxt1221 · 2026-02-07T00:53:53Z

Look at your first commit. It contains packaging.

Superredstone · 2026-02-07T07:11:37Z

I hope that after this push everything is fine

Bot-wxt1221

lgtm

Superredstone · 2026-02-28T10:04:14Z

I still get the following error when building with buildGo126Module, I'm guessing that there are issues with how wails build works.

>   ERROR   err: exit status 1: stderr: go: go.mod requires go >= 1.26 (running go 1.25.7; GOTOOLCHAIN=local)

SuperSandro2000 · 2026-02-28T23:48:47Z

When rebasing against master it works for me but when I start it, I get this:

Please wrap that in.

Superredstone · 2026-03-01T01:00:37Z

When rebasing against master it works for me but when I start it, I get this:

Please wrap that in.

Doesn't embedding FFmpeg require for it to be built from source?

EDIT: to be clear FFmpeg gets downloaded as a binary if you press "Install now" and it works.

EDIT 2: some time ago i wasn't able to embed ffmpeg without rebuilding it from source (it requires a lot of time to compile), which was probably caused by a broken ffmpeg package.

Superredstone · 2026-03-01T08:40:02Z

I was able to update to 7.0.9 but I had not luck with 7.1.0.

Hythera · 2026-03-01T08:44:50Z

Doesn't embedding FFmpeg require for it to be built from source?

It shouldn't. What probably happened is that ffmpeg was updated on master and wasn't yet build by hydra and cached so you had to rebuild it manually.

Superredstone · 2026-03-01T11:27:09Z

I was now able to embed ffmpeg as a dependency, I hope that this is the correct way to do it and not an hack

    wrapProgram $out/bin/spotiflac \
      --prefix PATH : ${lib.makeBinPath [ ffmpeg_7-headless ]}

Superredstone · 2026-03-02T07:18:59Z

I finally managed to get version 7.1.0 to compile by forcefully switching the Go toolchain to 1.26.0, Wails wasn’t detecting it otherwise.

nixpkgs/pkgs/by-name/sp/spotiflac/package.nix

Lines 48 to 60 in 069292a

    
             overrideModAttrs = { 
        
               preBuild = '' 
        
                 GOTOOLCHAIN=go1.26.0 wails build -compiler '${go_1_26}/bin/go' -tags webkit2_41 -o spotiflac 
        
               ''; 
        
             }; 
        
             buildPhase = '' 
        
               runHook preBuild 
        
               GOTOOLCHAIN=go1.26.0 wails build -compiler '${go_1_26}/bin/go' -tags webkit2_41 -o spotiflac 
        
               runHook postBuild 
        
             '';

pkgs/by-name/sp/spotiflac/package.nix

aciceri · 2026-03-03T13:34:25Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 486412
Commit: 069292a01abb88e268d8201738605a4e9d723bf3

`x86_64-linux`

❌ 1 package failed to build:

spotiflac

`aarch64-linux`

❌ 1 package failed to build:

spotiflac

aciceri

The build seems to fail now.
However I don't know if it's due to my environment but the window is glitched, wherever I move the cursor if I click it resizes the window and I can't focus the main textbox.

PS: please rename the PR's title with the new version

aciceri · 2026-03-03T13:37:09Z

pkgs/by-name/sp/spotiflac/package.nix

+  makeWrapper,
+}:
+
+buildGoModule (finalAttrs: {


Suggested change

buildGoModule (finalAttrs: {

buildGo126Module (finalAttrs: {

With just this change it seems to build.

pkgs/by-name/sp/spotiflac/package.nix

Superredstone · 2026-03-04T16:46:19Z

I assumed that buildGo126Module was not necessary as i explicitly specified what compiler to use.

Superredstone · 2026-03-04T16:58:42Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 486412
Commit: b7c30a38dc83f750d89b8d1dff33316254cf28ad

`x86_64-linux`

✅ 1 package built:

spotiflac

aciceri · 2026-03-04T17:05:18Z

I assumed that buildGo126Module was not necessary as i explicitly specified what compiler to use.

Look here, buildGoModule is just an alias for buildGo125Module.

SuperSandro2000

Tested this locally with a patch to wails to not override tools from PATH and it builds but I cannot force push it because the branch was opened from the default branch.

#497974

pkgs/by-name/sp/spotiflac/package.nix

sound-chimera · 2026-03-08T19:14:13Z

I've also experienced problems with small fonts and an unusable glitchy interface, it's probably because of this, and adding wrapGAppsHook3 to nativeBuildInputs fixed it for me locally.

SuperSandro2000 · 2026-03-10T19:19:47Z

Please rebase on master when the wails fix is merged and apply my suggested cleanups.

SuperSandro2000 · 2026-03-10T19:20:22Z

pkgs/by-name/sp/spotiflac/package.nix

+    pnpm_10
+    wails
+    makeWrapper
+    wrapGAppsHook3


We are now double wrapping, so please disable the automatic wrapping with gapps and manually add it to makeWrapper.

dontWrapGApps = true; makeWrapperArgs = [ "\${gappsWrapperArgs[@]}" ];

Is this correct?

Superredstone force-pushed the master branch from 901e3e7 to 233bbdf Compare February 5, 2026 13:45

nixpkgs-ci bot removed the 8.has: package (new) This PR adds a new package label Feb 5, 2026

Superredstone force-pushed the master branch from 233bbdf to 0c9c4b1 Compare February 5, 2026 20:53

nixpkgs-ci bot added the 8.has: package (new) This PR adds a new package label Feb 5, 2026

Bot-wxt1221 reviewed Feb 6, 2026

View reviewed changes

pkgs/by-name/sp/spotiflac/package.nix Show resolved Hide resolved

Bot-wxt1221 reviewed Feb 6, 2026

View reviewed changes

Superredstone force-pushed the master branch from 0c9c4b1 to 305aea8 Compare February 6, 2026 14:09

nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 6, 2026

Henry-Hiles approved these changes Feb 6, 2026

View reviewed changes

Henry-Hiles added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Feb 6, 2026

Superredstone force-pushed the master branch from 305aea8 to fa9b722 Compare February 6, 2026 14:36

nixpkgs-ci bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 6, 2026

Superredstone force-pushed the master branch from fa9b722 to 156d1c3 Compare February 7, 2026 07:09

Bot-wxt1221 approved these changes Feb 7, 2026

View reviewed changes

Superredstone changed the title ~~spotiflac: init at 7.0.7~~ spotiflac: init at 7.0.9 Mar 1, 2026

Superredstone force-pushed the master branch from c6df1f7 to 6b09947 Compare March 1, 2026 08:37

Superredstone force-pushed the master branch from 6b09947 to b2a9be9 Compare March 1, 2026 11:25

Superredstone force-pushed the master branch from b2a9be9 to 25bf89c Compare March 2, 2026 07:10

Superredstone changed the title ~~spotiflac: init at 7.0.9~~ spotiflac: init at 7.1.0 Mar 2, 2026

Superredstone force-pushed the master branch from 25bf89c to 069292a Compare March 2, 2026 07:11

sound-chimera reviewed Mar 3, 2026

View reviewed changes

pkgs/by-name/sp/spotiflac/package.nix Show resolved Hide resolved

aciceri suggested changes Mar 3, 2026

View reviewed changes

Superredstone force-pushed the master branch from 069292a to b7c30a3 Compare March 4, 2026 16:43

Superredstone requested a review from SuperSandro2000 March 8, 2026 07:26

SuperSandro2000 requested changes Mar 8, 2026

View reviewed changes

Superredstone force-pushed the master branch from fa47069 to 64a7daf Compare March 8, 2026 20:06

SuperSandro2000 reviewed Mar 10, 2026

View reviewed changes

Superredstone force-pushed the master branch from 64a7daf to 05fe398 Compare March 12, 2026 06:22

Superredstone added 2 commits March 12, 2026 07:37

maintainers: add Superredstone

1a073d1

spotiflac: init at 7.1.0

c34cae8

Superredstone force-pushed the master branch from 05fe398 to c34cae8 Compare March 12, 2026 06:37

Uh oh!

Conversation

Superredstone commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Henry-Hiles commented Feb 5, 2026

Uh oh!

Superredstone commented Feb 5, 2026

Uh oh!

Henry-Hiles commented Feb 5, 2026

Uh oh!

Superredstone commented Feb 5, 2026

Uh oh!

Henry-Hiles commented Feb 5, 2026

Uh oh!

Superredstone commented Feb 5, 2026

Uh oh!

Uh oh!

Bot-wxt1221 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Superredstone Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Henry-Hiles left a comment

Choose a reason for hiding this comment

Uh oh!

Bot-wxt1221 commented Feb 7, 2026

Uh oh!

Superredstone commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bot-wxt1221 left a comment

Choose a reason for hiding this comment

Uh oh!

Superredstone commented Feb 28, 2026

Uh oh!

SuperSandro2000 commented Feb 28, 2026

Uh oh!

Superredstone commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Superredstone commented Mar 1, 2026

Uh oh!

Hythera commented Mar 1, 2026

Uh oh!

Superredstone commented Mar 1, 2026

Uh oh!

Superredstone commented Mar 2, 2026

Uh oh!

Uh oh!

aciceri commented Mar 3, 2026

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

aciceri left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aciceri Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Superredstone commented Mar 4, 2026

Uh oh!

Superredstone commented Mar 4, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

aciceri commented Mar 4, 2026

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Superredstone commented Feb 2, 2026 •

edited

Loading

Superredstone Feb 6, 2026 •

edited

Loading

Superredstone commented Feb 7, 2026 •

edited

Loading

Superredstone commented Mar 1, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

aciceri left a comment •

edited

Loading

aciceri Mar 3, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`