Skip to content

Remove single-pass review flow, always use two-pass validator #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
factory-nizar merged 2 commits into from
Mar 5, 2026
Merged

Remove single-pass review flow, always use two-pass validator #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15e4fac
Remove single-pass review flow, always use two-pass validator
factory-nizar Mar 5, 2026
fe9ae5f
Merge remote-tracking branch 'origin/dev' into feat/remove-single-pas…
factory-nizar Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,12 @@ inputs:
description: "Override reasoning effort for review flows (passed to Droid Exec as --reasoning-effort). If empty and review_model is also empty, the action defaults internally to gpt-5.2 at high reasoning."
required: false
default: "high"
review_use_validator:
description: "Enable two-pass review: generate candidate comments to JSON, then validate and post only approved ones."
required: false
default: "true"
review_candidates_path:
description: "Path to write review candidates JSON (run #1 when review_use_validator=true)."
description: "Path to write review candidates JSON (pass 1 of the two-pass review)."
required: false
default: "${{ runner.temp }}/droid-prompts/review_candidates.json"
review_validated_path:
description: "Path to write review validated JSON (run #2 when review_use_validator=true)."
description: "Path to write review validated JSON (pass 2 of the two-pass review)."
required: false
default: "${{ runner.temp }}/droid-prompts/review_validated.json"
fill_model:
Expand Down Expand Up @@ -189,7 +185,6 @@ runs:
SECURITY_SCAN_DAYS: ${{ inputs.security_scan_days }}
REVIEW_MODEL: ${{ inputs.review_model }}
REASONING_EFFORT: ${{ inputs.reasoning_effort }}
REVIEW_USE_VALIDATOR: ${{ inputs.review_use_validator }}
REVIEW_CANDIDATES_PATH: ${{ inputs.review_candidates_path }}
REVIEW_VALIDATED_PATH: ${{ inputs.review_validated_path }}
FILL_MODEL: ${{ inputs.fill_model }}
Expand Down Expand Up @@ -336,13 +331,12 @@ runs:

- name: Prepare validator
id: prepare_validator
if: steps.prepare.outputs.contains_trigger == 'true' && inputs.review_use_validator == 'true' && steps.prepare.outputs.run_code_review == 'true'
if: steps.prepare.outputs.contains_trigger == 'true' && steps.prepare.outputs.run_code_review == 'true'
shell: bash
run: |
bun run ${GITHUB_ACTION_PATH}/src/entrypoints/prepare-validator.ts
env:
GITHUB_TOKEN: ${{ steps.prepare.outputs.github_token }}
REVIEW_USE_VALIDATOR: ${{ inputs.review_use_validator }}
REVIEW_VALIDATED_PATH: ${{ inputs.review_validated_path }}
REVIEW_CANDIDATES_PATH: ${{ inputs.review_candidates_path }}
DROID_COMMENT_ID: ${{ steps.prepare.outputs.droid_comment_id }}
Expand All @@ -351,7 +345,7 @@ runs:

- name: Run Droid Exec (validator)
id: droid_validator
if: steps.prepare.outputs.contains_trigger == 'true' && inputs.review_use_validator == 'true' && steps.prepare.outputs.run_code_review == 'true'
if: steps.prepare.outputs.contains_trigger == 'true' && steps.prepare.outputs.run_code_review == 'true'
shell: bash
run: |

Expand Down Expand Up @@ -389,7 +383,7 @@ runs:
GITHUB_EVENT_NAME: ${{ github.event_name }}
TRIGGER_COMMENT_ID: ${{ github.event.comment.id }}
IS_PR: ${{ github.event.issue.pull_request != null || github.event_name == 'pull_request_target' || github.event_name == 'pull_request_review_comment' }}
DROID_SUCCESS: ${{ (inputs.review_use_validator == 'true' && steps.prepare.outputs.run_code_review == 'true' && steps.droid_validator.outputs.conclusion == 'success') || (!(inputs.review_use_validator == 'true' && steps.prepare.outputs.run_code_review == 'true') && steps.droid.outputs.conclusion == 'success') }}
DROID_SUCCESS: ${{ (steps.prepare.outputs.run_code_review == 'true' && steps.droid_validator.outputs.conclusion == 'success') || (steps.prepare.outputs.run_code_review != 'true' && steps.droid.outputs.conclusion == 'success') }}
TRIGGER_USERNAME: ${{ github.event.comment.user.login || github.event.issue.user.login || github.event.pull_request.user.login || github.event.sender.login || github.triggering_actor || github.actor || '' }}
PREPARE_SUCCESS: ${{ steps.prepare.outcome == 'success' }}
PREPARE_ERROR: ${{ steps.prepare.outputs.prepare_error || '' }}
Expand Down
10 changes: 1 addition & 9 deletions review/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ inputs:
description: "Path to write review results JSON"
required: false
default: ""
review_use_validator:
description: "Enable two-pass review: generate candidate comments, then validate and post only approved ones."
required: false
default: "true"
review_candidates_path:
description: "Path to write review candidates JSON (pass 1)."
required: false
Expand Down Expand Up @@ -84,7 +80,6 @@ runs:
DROID_COMMENT_ID: ${{ inputs.tracking_comment_id }}
REVIEW_MODEL: ${{ inputs.review_model }}
REVIEW_TYPE: "code"
REVIEW_USE_VALIDATOR: ${{ inputs.review_use_validator }}
REVIEW_CANDIDATES_PATH: ${{ inputs.review_candidates_path }}
REASONING_EFFORT: ${{ inputs.reasoning_effort }}
DROID_OUTPUT_FILE: ${{ inputs.output_file }}
Expand Down Expand Up @@ -113,13 +108,11 @@ runs:

- name: Prepare Validator
id: prepare_validator
if: steps.prompt.outputs.review_use_validator == 'true'
shell: bash
run: |
bun run ${{ github.action_path }}/../src/entrypoints/prepare-validator.ts
env:
GITHUB_TOKEN: ${{ steps.token.outputs.github_token }}
REVIEW_USE_VALIDATOR: ${{ inputs.review_use_validator }}
REVIEW_VALIDATED_PATH: ${{ inputs.review_validated_path }}
REVIEW_CANDIDATES_PATH: ${{ inputs.review_candidates_path }}
REVIEW_MODEL: ${{ inputs.review_model }}
Expand All @@ -128,7 +121,6 @@ runs:

- name: Run Validator
id: validator
if: steps.prompt.outputs.review_use_validator == 'true'
shell: bash
run: |
bun run ${{ github.action_path }}/../base-action/src/index.ts
Expand All @@ -153,4 +145,4 @@ runs:
OUTPUT_FILE: ${{ inputs.output_file }}
TRIGGER_USERNAME: ${{ github.event.pull_request.user.login || github.event.sender.login || github.triggering_actor || github.actor || '' }}
PREPARE_SUCCESS: "true"
DROID_SUCCESS: ${{ (steps.prompt.outputs.review_use_validator == 'true' && steps.validator.outcome == 'success') || (steps.prompt.outputs.review_use_validator != 'true' && steps.review.outcome == 'success') }}
DROID_SUCCESS: ${{ steps.validator.outcome == 'success' }}
Loading