Remove single-pass review flow, always use two-pass validator#59
Merged
factory-nizar merged 2 commits intodevfrom Mar 5, 2026
Merged
Remove single-pass review flow, always use two-pass validator#59factory-nizar merged 2 commits intodevfrom
factory-nizar merged 2 commits intodevfrom
Conversation
Contributor
|
Droid finished @factory-nizar's task —— View job |
The single-pass review flow was initially created because we were unsure about the performance of the two-pass validator flow. The two-pass flow has since become the default and proven itself, and the single-pass flow is no longer used. This removes the review_use_validator toggle and all single-pass review code. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-nizar
force-pushed
the
feat/remove-single-pass-review
branch
from
fd891d1 to
15e4fac
Compare
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR cleanly removes the single-pass review flow and simplifies all conditional logic to always use the two-pass validator. No actionable bugs were found — the three candidate issues were either pre-existing behaviors unchanged by this PR or test code hygiene concerns that don't cause failures.
jonathan-factory
previously approved these changes
Mar 5, 2026
…s-review # Conflicts: # src/create-prompt/templates/review-prompt.ts # test/create-prompt/templates/review-prompt.test.ts
jonathan-factory
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the single-pass review flow and the
review_use_validatortoggle. Code reviews now always use the two-pass validator flow (candidate generation + validation).closes FAC-16898
Motivation
The single-pass review flow was initially created because we were unsure about the performance of the two-pass validator flow. The two-pass flow has since become the default and proven reliable, and the single-pass flow is no longer used by anyone.
Changes
review_use_validatorinput fromaction.ymlandreview/action.ymlsrc/create-prompt/templates/review-prompt.ts(single-pass prompt template)src/tag/commands/review.tssrc/entrypoints/generate-review-prompt.tssrc/entrypoints/prepare-validator.tsreview_use_validator)DROID_SUCCESSexpression in both action filestest/create-prompt/templates/review-prompt.test.tsBreaking Change
Users who explicitly set
review_use_validator: falsewill now have the input silently ignored -- reviews will always use the two-pass flow. This is intentional as the single-pass flow was not actively used.