Skip to content

Fixed Satisfy Number Case Rule Bug #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busabj merged 2 commits into from
Feb 10, 2026
Merged

Fixed Satisfy Number Case Rule Bug #960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be05d7
Fixed Satisfy Number Case Rule Bug
busabj Feb 10, 2026
cda213f
rid unnecessary comment
busabj Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/main/java/edu/rpi/legup/puzzle/lightup/rules/SatisfyNumberCaseRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,20 @@ private void generateCases(
LightUpBoard curBoard,
int index) {
if (num <= curBoard.getModifiedData().size()) {
// Mark remaining open spots (that didn't get bulbs) as empty
for (LightUpCell openSpot : openSpots) {
Point loc = openSpot.getLocation();
LightUpCell cell = curBoard.getCell(loc.x, loc.y);

// If this cell wasn't already marked with a bulb, mark it as empty
if (!curBoard.getModifiedData().contains(cell)) {
LightUpCell emptyCell = cell.copy();
emptyCell.setData(LightUpCellType.EMPTY.value);
curBoard.setCell(loc.x, loc.y, emptyCell);
curBoard.addModifiedData(emptyCell);
}
}

cases.add(curBoard);
return;
}
Expand All @@ -161,13 +175,13 @@ private void generateCases(
LightUpCell modCell = (LightUpCell) mod.copy();
Point modLoc = modCell.getLocation();

modCell.setData(-4);
modCell.setData(LightUpCellType.BULB.value);

newCase.setCell(modLoc.x, modLoc.y, modCell);
newCase.addModifiedData(modCell);
}

newCell.setData(-4);
newCell.setData(LightUpCellType.BULB.value);

newCase.setCell(loc.x, loc.y, newCell);
newCase.addModifiedData(newCell);
Expand Down