Fixed Satisfy Number Case Rule Bug#960
Merged
busabj merged 2 commits intoBram-Hub:devfrom Feb 10, 2026
Merged
Conversation
jadeandtea
approved these changes
Feb 10, 2026
Collaborator
jadeandtea
left a comment
There was a problem hiding this comment.
Looks like the case rule works as shown in the rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In SatisfyNumberCaseRule.java, in the second generateCases() method, I added a loop and conditional checking for adjacent cells without lightbulb and changing them to be dotted. For context, there was an issue in the LightUp game where the Satisfy Number rule was not doing as it should. It is supposed to make cells adjacent to a number cell that are not a light bulb into a dotted cell. It was not making the cells dotted, so only the light bulb cell was showing up.
Closes #565
Type of change
How Has This Been Tested?
To test this, I ran different boards and used the Satisfy Number case rule on different numbered cells. I checked all the produced cases, and the correct cells were now dotted.
To reproduce, open lightup, 7x7 Easy, board 393454, click Case Rules, click Satisfy Number, then click any numbered cell.
Checklist: