Skip to content

Fixed Satisfy Number Case Rule Bug#960

Merged
busabj merged 2 commits intoBram-Hub:devfrom
busabj:Satisfy-Number-Issue
Feb 10, 2026
Merged

Fixed Satisfy Number Case Rule Bug#960
busabj merged 2 commits intoBram-Hub:devfrom
busabj:Satisfy-Number-Issue

Conversation

@busabj
Copy link
Collaborator

@busabj busabj commented Feb 10, 2026

Description

In SatisfyNumberCaseRule.java, in the second generateCases() method, I added a loop and conditional checking for adjacent cells without lightbulb and changing them to be dotted. For context, there was an issue in the LightUp game where the Satisfy Number rule was not doing as it should. It is supposed to make cells adjacent to a number cell that are not a light bulb into a dotted cell. It was not making the cells dotted, so only the light bulb cell was showing up.

Closes #565

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

To test this, I ran different boards and used the Satisfy Number case rule on different numbered cells. I checked all the produced cases, and the correct cells were now dotted.
To reproduce, open lightup, 7x7 Easy, board 393454, click Case Rules, click Satisfy Number, then click any numbered cell.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jadeandtea jadeandtea changed the base branch from master to dev February 10, 2026 21:55
Copy link
Collaborator

@jadeandtea jadeandtea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the case rule works as shown in the rule

@busabj busabj merged commit c2f5c26 into Bram-Hub:dev Feb 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants