[Cloud] Add Bleu to the Known Clouds list#32856
[Cloud] Add Bleu to the Known Clouds list#32856kloudkrafts wants to merge 4 commits intoAzure:devfrom
Conversation
Added the Bleu Cloud Config (name, endpoints and suffixes) to the hard coded list of known clouds, along with AzureCloud, Azure US Gov Cloud, Azure China and Azure German Gov. The aim is to provide Bleu users the correct configuration out-of-the box with the next Azure CLI version, rather than having to add the config manually.
kloudkrafts
requested review from
DanielMicrosoft,
ReaNAiveD,
bebound,
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution @kloudkrafts! We will review the pull request and get back to you soon. |
kloudkrafts
left a comment
kloudkrafts
left a comment
There was a problem hiding this comment.
@microsoft-github-policy-service agree
benmille
left a comment
benmille
left a comment
There was a problem hiding this comment.
I work as a Cloud Architect at Bleu. I can confirm the endpoints and suffixes in this PR are correct and match our environment.
We currently have users manually registering the cloud via az cloud register, so having BleuCloud shipped as a known cloud would significantly improve the onboarding experience.
LGTM 👍
@microsoft-github-policy-service agree |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @kloudkrafts AFAIK users of Azure CLI on Bleu, they don't just download and install CLI, their CLI is installed and pre-configured by a tool called "Bootstrapper", which sets up the cloud environment just as your PR does. Correct me if I'm wrong but it doesn't seem necessary to hardcode Bleu in CLI. @jiasli to comment on whether there's a reason air-gapped clouds are not in the predefined cloud configurations of CLI. |
|
My understanding is that air-gapped clouds are private clouds and should not be exposed to the public. |
|
Hi @isra-fel & @jiasli, thanks for the review and the questions! Just a small clarification: Bleu is not an air-gapped cloud. It's part of Microsoft's National Partner Clouds. Independently operated Azure environment but that is publicly accessible over the internet. Bleu is a public cloud offering. Regarding the Bootstrapper: today, Bleu customers download the CLI tools and manually run az cloud register + az cloud set to configure their environment. For customers working with multiple clouds, being able to simply switch with az cloud set --name BleuCloud without having to register all endpoints and suffixes first would be a big improvement. Happy to help with any questions or provide more context! |
|
Thanks! I'm also checking with some internal teams... |
|
Thanks @isra-fel ! Regarding the name, you have a valid point ; we did have some internal debates about it, and the choice of naming "BleuCloud" boils down to customer perception. An important part of our business appeal is that even though we provide the same Azure technology, we are a juridically distinct company, operating independently from Microsoft - hence providing resilience from US extra-territorial laws. Labeling it "AzureFranceCloud" could give the impression that this option is for a local MS subsidiary running Azure like a French equivalent of Azure US Gov. Another option would be "AzureBleuCloud", which would be a bit more verbose than "BleuCloud" but bring the same level of clarity. Would that be acceptable ? Thanks |
7 participants
Related command
az cloud set -n BleuCloud
Description
Added the Bleu Cloud Config (name, endpoints and suffixes) to the hard coded list of known clouds, along with AzureCloud, Azure US Gov Cloud, Azure China and Azure German Gov. The aim is to provide Bleu users the correct configuration out-of-the box with the next Azure CLI version, rather than having to add the config manually.
Testing Guide
This change should be covered by the existing unit tests, namely test_get_known_clouds.
The endpoints and config should appear with "az cloud show -n BleuCloud".
When BleuCloud is set, "az login" should get a successful response.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.