Closed
Conversation
* flush buffer on drain * add some log for debuging * remove some debug log * remove the debug logs * change error log to debug
Owner
|
Well done. I will review it first to ensure it does not cause any new issues. |
zishang520
reviewed
Jul 21, 2025
Owner
zishang520
left a comment
There was a problem hiding this comment.
Looking forward to your response.
Owner
|
Please hold on while I reassess the new content you submitted. |
Author
|
Hi, how is the review going? Is there anything else that needs to be revised? |
zishang520
reviewed
Jul 25, 2025
Owner
zishang520
left a comment
There was a problem hiding this comment.
Removing s.server.Emit("drain", s) and s.Emit("drain") will cause
Lines 562 to 565 in 52d56d1
Owner
|
This repository and its history have been merged into the Socket.IO monorepo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes zishang520/socket.io#101