Skip to content

Conversation

@Pitrick3141
Copy link
Contributor

Summary

This PR implements CLI support for Pinecone within the VectorDBBench framework. It adds the necessary command-line interface logic, updates dependencies, and registers the Pinecone command to the main entry point.

Changes

  1. Dependency Updates
  • install/requirements_py3.11.txt: Swapped pinecone-client for pinecone.
  • pyproject.toml: Updated dependencies and optional extras to use the pinecone package.
  1. New CLI Implementation
    vectordb_bench/backend/clients/pinecone/cli.py:
  • Created PineconeTypedDict to define CLI arguments: --api-key, --index-name, --version, and --note.
  • Implemented the Pinecone command function using the run helper.
  • Integrated PineconeConfig and EmptyDBCaseConfig for database initialization.
  1. CLI Registration
  • vectordb_bench/cli/vectordbbench.py:
  • Imported the new Pinecone command.
  • Registered Pinecone to the main cli group.

Verification Results

  • Dependency Check: Verified pinecone package replaces the deprecated pinecone-client.
  • CLI Functionality: The Pinecone command is now accessible via the global CLI.

@XuanYang-cn
Copy link
Collaborator

@Pitrick3141 Please format the code with "make format" to pass the action

@Pitrick3141
Copy link
Contributor Author

@Pitrick3141 Please format the code with "make format" to pass the action

Hi XuanYang, I have formatted the code as suggested, thanks.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pitrick3141, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn merged commit f35f648 into zilliztech:main Feb 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants