Skip to content

Conversation

@xihale
Copy link
Member

@xihale xihale commented Jan 25, 2026

上游已经修复了 Access-Control-Allow-Origin 缺失的相关问题,可以加入 integrity 验证确保资源安全。

@gemini-code-assist
Copy link

Summary of Changes

Hello @xihale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the security posture of the application by implementing Subresource Integrity (SRI) and appropriate crossorigin attributes for external CDN-hosted assets. This change ensures that resources like KaTeX and Mermaid are loaded securely, verifying their integrity against known cryptographic hashes and mitigating risks associated with compromised content delivery networks.

Highlights

  • Enhanced Security for CDN Resources: Subresource Integrity (SRI) hashes have been added to all CDN-hosted KaTeX and Mermaid resources to ensure their authenticity and prevent tampering.
  • Cross-Origin Resource Sharing (CORS) Configuration: The crossorigin="anonymous" attribute has been included for these CDN resources, which is essential for enabling SRI checks and preventing potential CORS-related issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances security by adding Subresource Integrity (SRI) hashes and crossorigin attributes to all CDN-hosted resources. This is an excellent security practice that helps prevent attacks from a compromised CDN. The changes are correct and well-implemented. I've added a few minor suggestions to improve code readability by formatting some of the long lines.

@xihale xihale merged commit 2740a44 into zigcc:main Jan 25, 2026
2 of 3 checks passed
@xihale xihale deleted the fix-cdn branch January 25, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant