Fix -Wunused-but-set-variable warnings from Clang#342
Open
Quuxplusone wants to merge 1 commit intozenorogue:masterfrom
Open
Fix -Wunused-but-set-variable warnings from Clang#342Quuxplusone wants to merge 1 commit intozenorogue:masterfrom
Quuxplusone wants to merge 1 commit intozenorogue:masterfrom
Conversation
Quuxplusone
force-pushed
the
dead-writes
branch
from
9fe2c0d to
4c39f89
Compare
Quuxplusone
commented
Dec 13, 2024
|
|
||
| int a0 = 0; | ||
| for(auto& dd: ad) if(dd == 1) a0++; | ||
| return a < 6; |
Contributor
Author
There was a problem hiding this comment.
This one still seems suspect to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You should take a close look at each of these removals, because they might indicate a typo further down — maybe the variable was intended to be used, but accidentally wasn't. For example,
return a < 6;is very suspicious: should it have beenreturn a0 < 6;?