build(deps): bump actions/checkout from 4 to 5#6
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
build(deps): bump actions/checkout from 4 to 5#6dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
zakariaf
pushed a commit
that referenced
this pull request
Nov 13, 2025
…rformance improvements Fix all issues identified in PR review by gemini-code-assist bot. HIGH PRIORITY FIXES: 1. EmbeddingVector validation (Issue #1) - Replace no-op field_validator with @model_validator - Move dimension matching validation from factory to model validator - Move NaN/Inf detection from factory to model validator - Now validates on direct instantiation, not just via create() 2. RateLimitInfo validation (Issue #2) - Replace no-op field_validator with @model_validator - Enforce requests_remaining <= limit constraint - Validation now happens on all instantiation paths 3. CacheStatistics validation (Issue #3) - Replace field_validator with @model_validator - Validate total_queries = cache_hits + cache_misses - Validate cache_hits = exact_hits + semantic_hits - Proper cross-field validation with model_validator MEDIUM PRIORITY FIXES: 4. AuditLogSummary performance (Issue #4) - Consolidate 6 separate list iterations into single loop - Major performance improvement for large audit log datasets - Reduced from O(6n) to O(n) complexity 5. ProviderRegistry mutability (Issue #5) - Remove unconventional object.__setattr__() usage - Use direct mutation (Pydantic models are mutable) - Cleaner, more idiomatic code in register() and set_default() 6. Test consistency (Issue #6) - Replace try/except blocks with pytest.raises context manager - Updated 5 test methods in test_cache_entry.py - Consistent with other test files in the project BENEFITS: - Validates on all instantiation paths, not just factory methods - Better performance with consolidated iterations - More maintainable code without object.__setattr__ - Consistent testing patterns across all test files - Proper Pydantic validation best practices Files modified: - app/models/embedding.py: model_validator for dimensions + NaN/Inf - app/models/ratelimit.py: model_validator for requests_remaining - app/models/statistics.py: model_validator for cross-field validation - app/models/audit.py: single-loop optimization - app/models/provider.py: removed object.__setattr__ - tests/unit/models/test_cache_entry.py: pytest.raises pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 4 to 5.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
08c6903Prepare v5.0.0 release (#2238)9f26565Update actions checkout to use node 24 (#2226)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)