important fix to iPhone6 support (for cocoapods library usage)#13
Open
robertibiris wants to merge 7 commits intoyuvirajsinh:masterfrom
Open
important fix to iPhone6 support (for cocoapods library usage)#13robertibiris wants to merge 7 commits intoyuvirajsinh:masterfrom
robertibiris wants to merge 7 commits intoyuvirajsinh:masterfrom
Conversation
added 7 commits
March 4, 2015 19:53
…ed by the demo are different than those included in the cocoa pods repo, hence the confusion
…r the cameraController. -status bar hidden when showing cameraController
…ts using Frameworks feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on the previous pul request, the files changed were the ones used in the Demo project. However, these are not the ones tracked in the podspec file, so I updated the ones tracked by the podspec file in order for the library to match the changed reflected in the demo.
As a suggestion, it might be better to set the files used by the Demo as the same ones used for Cocoapods (at the moment they's just copies of each other basically). In this way we can avoid confusion in future pull requests.
cheers =)