Conversation
|
@jhampton, adding you as a reviewer here for context. This failure is legit; it is the failure I fixed in my other PR. Once that one gets merged, we will be able to update this pr and should see the test pass here. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile OverviewGreptile SummaryAdded new GitHub Actions workflow to test iOS example app builds on pull requests to main branch
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant PR as Pull Request
participant GHA as GitHub Actions
participant Node as Node.js Setup
participant Expo as Expo Prebuild
participant Ruby as Ruby/Bundler
participant Xcode as Xcode Build
PR->>GHA: Trigger on PR to main
GHA->>GHA: Checkout repository
GHA->>Xcode: Select latest-stable Xcode
GHA->>Node: Setup Node 20 with npm cache
Node->>GHA: Install root dependencies (npm ci)
Node->>GHA: Install example dependencies (npm ci)
GHA->>Expo: Run expo prebuild --clean --platform ios
Expo->>GHA: Generate ios/ directory with native code
GHA->>Ruby: Setup Ruby 3.2 with bundler cache
Ruby->>GHA: Install CocoaPods (pod install)
GHA->>Xcode: Build iOS app (npm run ios --no-install)
Xcode->>GHA: Build result
GHA->>PR: Report success/failure
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
jhampton
left a comment
There was a problem hiding this comment.
Small suggestion on the comment for future improvement, otherwise LGTM once it runs successfully. https://github.com/youversion/platform-sdk-reactnative/actions/runs/21490549279 shows an error about missing "jobs", suggestion below.
Co-authored-by: Jeff Hampton <jhampton@gmail.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
|
@jhampton how about we go ahead and merge this and we can track somewhere the possible improvements. |
Description
We had gotten the repo in a state where the IOS example app build was failing. This puts in place a CI test to make sure it passes on PR's
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist