Open
Conversation
Oppen
reviewed
Dec 18, 2024
Oppen
reviewed
Dec 18, 2024
8e072ed to
02b77ff
Compare
that automatically adds a root authority
02b77ff to
4d7e939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support TLS in batcher connections
Description
Before this PR, the TLS connections where handled by a Caddy in the batcher servers.
Now with this PR, the TLS is handled directly in the batcher.
Notes for testing
As mentioned in the updated guide, you'll need to install
mkcert. When running themake batcher_start_localcommand for the first time, it'll ask for authentication to install a locally generated root certificate. It's only needed for devnet.You should be able to send and verify proofs normally after that.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging