Task id parameter in task card macro shows "WebHome" for tasks created using the task macro#335
Open
petrenkonikita112263 wants to merge 1 commit intoxwikisas:masterfrom
Open
Conversation
…d using the task macro xwikisas#99 * Add logic that uses document name from Task object as label or if such object is missing, then to use document name * add missing empty space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm retrieving from document an object of
TaskManager.TaskManagerClass, and if task has such object then setting the label as property value. Otherwise, the name of the task will be used. During additional tests, I notified that this fix perfectly works if such condition is met: created task via macro or quick actions has at least name. But this low probability can be dismissed, I doubt as a user creating empty tasks from macros or commands in the end.Before PR:
After PR:
Executed Tests
None