refactor outbound sender to allow for multiple modes of dispatch#614
Draft
piccione99 wants to merge 9 commits intomainfrom
Draft
refactor outbound sender to allow for multiple modes of dispatch#614piccione99 wants to merge 9 commits intomainfrom
piccione99 wants to merge 9 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 53.89% 55.73% +1.83%
==========================================
Files 9 16 +7
Lines 1334 1830 +496
==========================================
+ Hits 719 1020 +301
- Misses 574 749 +175
- Partials 41 61 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
piccione99
commented
Sep 8, 2025
dispatcher.go
Outdated
| Send(urls *ring.Ring, secret, acceptType string, msg *wrp.Message) | ||
| } | ||
|
|
||
| func DispatcherFactory(webhook bool, obs *CaduceusOutboundSender) Dispatcher { |
piccione99
commented
Sep 8, 2025
outboundSender_test.go
Outdated
| } | ||
|
|
||
| obs.(*CaduceusOutboundSender).queueOverflow() | ||
| obs.(*WebhookOutboundSender).obs.dispatcher.QueueOverflow() |
Contributor
Author
There was a problem hiding this comment.
this will eventually also return StreamOutboundSender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added kinesis and batch packages, but they aren't used yet, please ignore them for reviewing.
OutboundSender contains the common functionality for WebhookOutboundSender and eventually StreamOutboundSender. t
However, OutboundSender has the Update function that takes ancla.Webhook so it doesn't really fit that well with StreamOutboundSender. So, that is a code smell that probably needs to be addressed. That said, we might want to actually update stream senders from Argus so we don't have to reboot caduceus. Initially this will be a predefined set of streams and we need to manually add them to headwaters, so it can't be entirely automated. But would be nice to not have to redeploy caduceus.