CA-417888: Check if dracut exists before calling weak_module in dmv.py#183
Merged
stephenchengCloud merged 1 commit intoxenserver:masterfrom Sep 30, 2025
Conversation
Contributor
Author
|
Tested: |
The install image doesn’t have dracut installed, while dmv.py calls weak_module which indirectly calls dracut when selecting drivers in install enviornment. Signed-off-by: Stephen Cheng <stephen.cheng@citrix.com>
stephenchengCloud
force-pushed
the
private/stephenche/CA-417888
branch
from
6520cf4 to
36f855a
Compare
Contributor
Author
|
Fixed pylint warning |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
========================================
- Coverage 83.3% 83.2% -0.1%
========================================
Files 23 23
Lines 3347 3348 +1
========================================
- Hits 2790 2788 -2
- Misses 557 560 +3
|
DeliZhangX
approved these changes
Sep 30, 2025
chunjiez
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install image doesn’t have dracut installed,
while dmv.py calls weak_module which indirectly calls dracut when selecting drivers in install enviornment.