Merged
Conversation
douzzer
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The t2b() function now passes through bytes, bytearray, and memoryview types unchanged, instead of only accepting bytes. This allows interfaces throughout the codebase that use t2b() to automatically support these additional buffer types.
Also dropped Python 2 compatibility code since it's no longer needed.
The ChaCha20Poly1305 class needed to wrap input arguments in _ffi.from_buffer() when passing them to C functions. This is required because CFFI's from_buffer() converts Python buffer objects (including memoryview and bytearray) to C-compatible pointers.
These changes allow memoryview and bytearray types to be used with MlKemPublic.decode_key(), ChaCha20Poly1305.decrypt(), and other interfaces that accept binary data.
Cursor assisted PR
Fixes #81