-
-
Notifications
You must be signed in to change notification settings - Fork 233
Fix dropdown yielding options as a collection. #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a runtime guard that converts Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@modules/backend/widgets/form/partials/_field_dropdown.php`:
- Around line 3-5: Adjust the indentation of the conditional that checks the
type of $fieldOptions so PHPCS expects 0 leading spaces: locate the block that
uses "if ($fieldOptions instanceof Illuminate\Support\Collection)" and the
subsequent "$fieldOptions = $fieldOptions->all();" and remove the extra leading
spaces so both lines begin at column 0 (no indentation).
Fixes #1445
Restores previous behavior.
Added a unittest that triggers the error in the form rendering.
Summary by CodeRabbit
Bug Fixes
Tests