Everyone likes to flow these days by jirikolarik · Pull Request #52 · werein/react

jirikolarik · 2017-10-24T13:08:54Z

https://medium.com/@jirikolarik/comprehensive-flow-with-react-redux-bd515d8d0e50

houndci-bot · 2017-10-24T13:09:08Z

src/store/index.js

 import { routerMiddleware, connectRouter } from 'connected-react-router';
 // Import all reducers
-import * as reducers from 'reducers';
+import * as reducers from 'reducers/index';


Unable to resolve path to module 'reducers/index' import/no-unresolved
Missing file extension for "reducers/index" import/extensions

houndci-bot · 2017-10-24T13:09:08Z

src/store/index.js

@@ -1,10 +1,12 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates
Resolve error: package.json not found in path import/extensions
Resolve error: package.json not found in path import/no-absolute-path

houndci-bot · 2017-10-24T13:09:08Z

src/routes.js

@@ -1,3 +1,5 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates
Resolve error: package.json not found in path import/extensions
Resolve error: package.json not found in path import/no-absolute-path
Resolve error: package.json not found in path import/no-named-as-default
Resolve error: package.json not found in path import/no-named-as-default-member

houndci-bot · 2017-10-24T13:09:09Z

src/reducers/index.js

+// @flow
+
+import type { Dispatch } from 'actions/index';
+import type { AppState } from './app';


Unable to resolve path to module './app' import/no-unresolved
Missing file extension for "./app" import/extensions

houndci-bot · 2017-10-24T13:09:09Z

src/reducers/index.js

@@ -1,3 +1,18 @@
+// @flow
+
+import type { Dispatch } from 'actions/index';


Unable to resolve path to module 'actions/index' import/no-unresolved
Missing file extension for "actions/index" import/extensions

houndci-bot · 2017-10-24T13:09:09Z

src/containers/layout.js

@@ -1,3 +1,5 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates
Resolve error: package.json not found in path import/extensions
Resolve error: package.json not found in path import/no-absolute-path
Resolve error: package.json not found in path import/no-named-as-default
Resolve error: package.json not found in path import/no-named-as-default-member

houndci-bot · 2017-10-24T13:09:09Z

src/containers/app.js


  render() {
-    if (!this.props.loaded) {
+    const { loaded } = this.props;


'loaded' is missing in props validation react/prop-types

houndci-bot · 2017-10-24T13:09:10Z

src/containers/app.js

  componentDidMount() {
-    this.props.dispatch(loadApp());
-  }
+    const { dispatch } = this.props;


'dispatch' is missing in props validation react/prop-types

houndci-bot · 2017-10-24T13:09:10Z

src/containers/app.js

 import { connect } from 'react-redux';
 import { loadApp } from 'actions/app';
+import type { Dispatch } from 'actions/index';
+import type { State } from 'reducers/index';


Unable to resolve path to module 'reducers/index' import/no-unresolved
Missing file extension for "reducers/index" import/extensions

houndci-bot · 2017-10-24T13:09:10Z

src/containers/app.js

 import React, { Component } from 'react';
 import { connect } from 'react-redux';
 import { loadApp } from 'actions/app';
+import type { Dispatch } from 'actions/index';


Unable to resolve path to module 'actions/index' import/no-unresolved
Missing file extension for "actions/index" import/extensions

houndci-bot · 2017-11-07T12:39:46Z

src/actions/app.js

@@ -1,6 +1,12 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates

houndci-bot · 2017-11-07T12:39:46Z

src/actions/index.js

+
+import type {
+  LoadApp
+} from './app';


Unable to resolve path to module './app' import/no-unresolved
Missing file extension for "./app" import/extensions

houndci-bot · 2017-11-07T12:39:46Z

src/actions/index.js

@@ -0,0 +1,9 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates
Resolve error: package.json not found in path import/extensions

houndci-bot · 2017-11-07T12:39:46Z

src/containers/app.js

 import { loadApp } from 'actions/app';
+import type { MapStateToProps } from 'react-redux';
+import type { Dispatch } from 'actions/index';
+import type { State } from 'reducers/index';


Unable to resolve path to module 'reducers/index' import/no-unresolved
Missing file extension for "reducers/index" import/extensions

houndci-bot · 2017-11-07T12:39:46Z

src/actions/app.js

@@ -1,6 +1,12 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates

houndci-bot · 2017-11-07T12:39:46Z

src/actions/index.js

+
+import type {
+  LoadApp
+} from './app';


Unable to resolve path to module './app' import/no-unresolved
Missing file extension for "./app" import/extensions

houndci-bot · 2017-11-07T12:39:47Z

src/actions/index.js

@@ -0,0 +1,9 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates
Resolve error: package.json not found in path import/extensions

houndci-bot · 2017-11-07T12:39:47Z

src/containers/app.js

 import { loadApp } from 'actions/app';
+import type { MapStateToProps } from 'react-redux';
+import type { Dispatch } from 'actions/index';
+import type { State } from 'reducers/index';


Unable to resolve path to module 'reducers/index' import/no-unresolved
Missing file extension for "reducers/index" import/extensions

houndci-bot · 2017-11-07T12:44:31Z

src/containers/app.js

 import { connect } from 'react-redux';
 import { loadApp } from 'actions/app';
+import type { MapStateToProps } from 'react-redux';
+import type { Dispatch } from 'actions/index';


Unable to resolve path to module 'actions/index' import/no-unresolved
Missing file extension for "actions/index" import/extensions

houndci-bot · 2017-11-07T12:44:31Z

src/containers/app.js

 import React, { Component } from 'react';
 import { connect } from 'react-redux';
 import { loadApp } from 'actions/app';
+import type { MapStateToProps } from 'react-redux';


Unable to resolve path to module 'react-redux' import/no-unresolved
Missing file extension for "react-redux" import/extensions

houndci-bot · 2017-11-07T12:44:31Z

src/containers/app.js

@@ -1,22 +1,32 @@
+// @flow


Resolve error: package.json not found in path import/no-unresolved
Resolve error: package.json not found in path import/no-duplicates
Resolve error: package.json not found in path import/extensions
Resolve error: package.json not found in path import/no-named-as-default
Resolve error: package.json not found in path import/no-named-as-default-member

everyone likes to flow these days

42ff73a

houndci-bot reviewed Oct 24, 2017

View reviewed changes

Add missing parts

6ead2ce

houndci-bot reviewed Nov 7, 2017

View reviewed changes

Update travis

4da639b

houndci-bot reviewed Nov 7, 2017

View reviewed changes

Jiri Kolarik added 2 commits November 7, 2017 13:54

Fix appveyor

73c523c

Install flowtype first

5d18b38

		@@ -1,3 +1,18 @@
		// @flow

		import type { Dispatch } from 'actions/index';

Conversation

jirikolarik commented Oct 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jirikolarik commented Oct 24, 2017 •

edited

Loading