Adding secret into ingress template#2085
Open
gitreich wants to merge 2 commits intowebrecorder:mainfrom
Open
Conversation
Member
|
Thanks for starting this! I was thinking we'd want to actually have the secret be created as part of the Helm chart, from the key and cert files themselves, eg something like: and then adding a Secret definition in secrets.yaml that creates the secret from these files. But, I think that does mean the cert and key files need to be in the same directory as the chart, which may be less than ideal... I guess providing a separate Secret might be easy enough, given that the user is responsible for managing it. For authsign, I think it'll need to be updated, since it doesn't really support working with external certs or k8s secrets at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For manually adding a secret for a tls of another authority then Let's Encrypt
See #2077
Fix for frontend&backend ingress
Still open: auth-signer is not using the same secret