RFC 80: Rename master branch to main in all repositories#80
RFC 80: Rename master branch to main in all repositories#80
Conversation
foolip
changed the title
rfcs/main_branch.md
Outdated
| - https://github.com/web-platform-tests/wpt.fyi | ||
| - https://github.com/web-platform-tests/wpt.live | ||
|
|
||
| TODO: which external repos hardcode the name of the default branch in any WPT repo? |
There was a problem hiding this comment.
Probably many bots that interact with wpt e.g. the gecko sync bot definitely has some hardcoded branch names.
There was a problem hiding this comment.
Yep, it's all over Chromium's 2-way sync too:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/tools/blinkpy/w3c/local_wpt.py;l=39;drc=d9363a8ca4d0967ce169cad2c9d25534a1e0c25a
There was a problem hiding this comment.
I wasn't planning to flesh this out today, but I think what I'd propose here to make the transition work is to have both main and master branch updated and kept in sync for a while, so that the migration in other repos can happen at a leisurely pace and not strongly coordinated with the default branch change.
The alternative of having other repos be able to handle both branch names and later clean it up seems riskier and very un-fun.
|
@stephenmcgruer and @Hexcles (feel free to unsubscribe) put together WPT and wpt.fyi - inclusive branch naming last year, which has much of the detail needed here. |
|
If someone would like to take over this RFC and drive it to completion, I would be very happy. It's a lot of work to ensure this change won't break anything given all the repos involved, and also things like https://wpt.fyi/results/?label=experimental&label=master&aligned where we'd need some changes in wpt.fyi. |
|
FYI, non-archived repos with default branches which aren't main: https://github.com/web-platform-tests/code-of-conduct-moderations (master) It does seem like we should be able to move almost all of these over with minimal risk. I do wonder if we should split this RFC into two, one covering WPT itself and one covering the rest. |
|
The second riskiest I think might be wpt-metadata, since there are multiple pieces of code creating automated pull requests. Creating a pull request requires a target branch, so that'll need updating. But I agree splitting into multiple RFC. For the not-wpt RFC, I expect the discussion to just be "try it and see what breaks", for wpt we need to be a bit more responsible. |
|
For anyone coming across this, I do not plan to work on this. Feel free to take it over as a new RFC and I will close this one. |
Co-authored-by: Sam Sneddon <gsnedders@apple.com>
3 participants
Rendered