Introduce max policy version for compatibility with newer CMake versions#36
Merged
walterschell merged 1 commit intowalterschell:masterfrom Apr 4, 2025
Merged
Conversation
Owner
|
Thanks for the fix. In order to preserve backward compatibility would you mind changing the fix to use |
e0abac3 to
03cfbe3
Compare
03cfbe3 to
c19bcf0
Compare
Contributor
Author
|
FYI, I was trying to test this, but I couldn't get a newer runner image to execute my CI job. I looked into it, and it appears that GitHub downgraded their CI runners to avoid the breakage they introduced. They're also working to pin the CMake version so they can upgrade without this error happening. Regardless, I went ahead and made the change you asked for. Perhaps it will come in handy for users running CMake 4.0. |
Owner
|
Thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions is updating to CMake 4.0.0 on all their Ubuntu runner images. This version has removed support for versions before CMake 3.5. Any chance we could get the minimum required version raised to resolve the following error?