Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UAC code for the Linux host, with modifications to header inclusions, source file paths, and IDE settings.
- Removed an unused header inclusion in JniJpegBenchmark.cpp.
- Changed the include style for turbojpeg in ImageUseCases.cpp.
- Updated file path references in CMakeLists.txt to reflect a reorganization into the src/ directory.
- Extended VS Code settings for additional C++ configurations.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libausbc/src/main/jni/UVCCamera/src/JniJpegBenchmark.cpp | Removed an unnecessary header inclusion. |
| libausbc/src/main/jni/UVCCamera/src/ImageUseCases.cpp | Updated turbojpeg include directive from angle brackets to quotes. |
| libausbc/src/main/jni/UVCCamera/CMakeLists.txt | Adjusted source file paths to use the new src/ directory structure. |
| .vscode/settings.json | Expanded configuration for additional C++ keywords and types. |
| #endif | ||
| #ifdef USE_TURBOJPEG | ||
| #include <turbojpeg.h> | ||
| #include "turbojpeg.h" |
There was a problem hiding this comment.
Verify whether the change from angle brackets to quotes for turbojpeg is intentional. If turbojpeg is provided as a system library, consider using angle brackets for clarity.
Suggested change
| #include "turbojpeg.h" | |
| #include <turbojpeg.h> |
| ${UVCCAMERA}/src/JniUVCCamera.cpp | ||
| ${UVCCAMERA}/src/JpegBenchmark.cpp | ||
| ${UVCCAMERA}/src/LoadJpegImageFromAssetsUseCase.cpp | ||
| ${UVCCAMERA}/src/JniJpegBenchmark.cpp |
There was a problem hiding this comment.
Ensure that the updated file paths in the CMakeLists.txt accurately reflect the new directory layout and that no outdated references remain.
Suggested change
| ${UVCCAMERA}/src/JniJpegBenchmark.cpp | |
| # Assuming the file has been removed from the project: | |
| # Remove the reference to JniJpegBenchmark.cpp | |
| # If the file has been moved, replace the path with the correct one. | |
| # Example if the file has been moved to a new location: | |
| # ${UVCCAMERA}/new_path/JniJpegBenchmark.cpp | |
| # Example if the file has been removed: | |
| # (Remove the line entirely) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.