Fixes an issue where boolean false set on deterministic fields are treated unexpectedly in requireWith and requireWithout validators.#358
Open
RickKukiela wants to merge 1 commit intovlucas:masterfrom
Conversation
…lidators which increase the specificity check on the deterministic field(s) in order to correctly treat a value of (bool)false as "not set". When not enabled, the old behavior of treating (bool)false as "set" is maintained. The flag was added in order to maintain backward compatibility. - Updates the README.md file to include details on using the new `$checkBool` flag on the `requiredWith` and `requiredWithout` validator sections. Example uses are included. - Updates the `tests/Valitron/ValidateTest.php` to duplicate all existing tests for `requiredWith` and `requiredWithout` but with the `$checkBool` flag enabled to verify backward compatibility. All tests pass. - Fixes the `testCreditCardInvalid()` and `testCreditCardValid()` methods by providing the card numbers as strings since the integer values were being converted to exponential notation on some environments causing the tests to fail. The credit card tests now pass. - Fixes a deprecation warning in `ValidateAddInstanceRuleTest::testUniqueRuleName()` where `$this->assertRegExp()` was deprecated. Replaced assert call with recommended replacement `$this->assertMatchesRegularExpression()`. The test now passes without warning. - Fixes a few other minor English / grammatical errors in the README.md and comments in the `requiredWith` and `requiredWithout` validators.
RickKukiela
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
$checkBoolflag in therequireWithandrequireWithoutvalidators which increase the specificity check on the deterministic field(s) in order to correctly treat a value of (bool)false as "not set". When not enabled, the old behavior of treating (bool)false as "set" is maintained. The flag was added in order to maintain backward compatibility.Full notes in commit log.