Thread being retired should not be preempted#345
Thread being retired should not be preempted#345lawkai-vivo wants to merge 2 commits intovivoblueos:mainfrom
Conversation
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22701067480. |
|
build_prs |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22701067480. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22701128131. |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22701128131. |
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22701990213. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22701990213. |
lawkai-vivo
force-pushed
the
fix-pendsv-race
branch
from
b994e14 to
f999fde
Compare
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22705661859. |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22705661859. |
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22706204383. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22706204383. |
lawkai-vivo
force-pushed
the
fix-pendsv-race
branch
from
6fc52a4 to
cc296b9
Compare
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22707916065. |
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22707968065. |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22707916065. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22707968065. |
Fix https://github.com/vivoblueos/kernel/actions/runs/22700766319/job/65817293534. ``` panicked at ../../kernel/kernel/src/scheduler/mod.rs:269:9: assertion `left == right` failed left: Err(4) right: Ok(()) Oops: assertion `left == right` failed ```
lawkai-vivo
force-pushed
the
fix-pendsv-race
branch
from
446e971 to
ceb2434
Compare
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22710399846. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22710399846. |
kernel/src/scheduler/mod.rs
Outdated
| if old.state() == thread::RETIRED { | ||
| let cleanup = old.lock().take_cleanup(); | ||
| if let Some(entry) = cleanup { | ||
| old.enable_preempt(); |
There was a problem hiding this comment.
If it's already going to retire, why do we still need to enable_preempt?
There was a problem hiding this comment.
You're right. Will seek another solution for the test threads.
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22714325253. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22714325253. |
2 participants
Fix https://github.com/vivoblueos/kernel/actions/runs/22700766319/job/65817293534.