Skip to content

Conversation

@nitedani
Copy link
Member

No description provided.

@brillout
Copy link
Member

@nitedani 👀 Shall I start reviewing this?

@nitedani
Copy link
Member Author

Not yet.

@brillout
Copy link
Member

👍 Let me know if you need anything from my side. (FYI vikejs/vike#2950.)

@brillout
Copy link
Member

I just 1. resolved lock file conflict and 2. aligned tsconfig.json with all other packages. No functional changes.

@nitedani
Copy link
Member Author

nitedani commented Jan 6, 2026

https://github.com/vikejs/vike/blob/a8c7987cf4ae3795359cedb4ed07ee8e64ef8abe/packages/vike/src/shared-server-client/hooks/execHook.ts#L222-L224

Need to add throw err after the line originalError = err for the onHookCall error capture to work.

brillout added a commit to vikejs/vike that referenced this pull request Jan 7, 2026
@brillout
Copy link
Member

brillout commented Jan 7, 2026

Need to add throw err after the line originalError = err for the onHookCall error capture to work.

Done (vikejs/vike#3020) & pre-released as 0.4.250-commit-0d50da9.

@nitedani nitedani marked this pull request as ready for review February 10, 2026 20:12
# `vike-react-sentry`

> [!WARNING]
> This extension is in **alpha**. It has only been tested with **Node.js** servers so far. Other runtimes (Cloudflare, Deno, Bun, etc.) are not yet supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you actually tried and can confirm it doesn't work, I'd suggest:

Suggested change
> This extension is in **alpha**. It has only been tested with **Node.js** servers so far. Other runtimes (Cloudflare, Deno, Bun, etc.) are not yet supported.
> This extension is in **beta**. It has only been tested with **Node.js** servers so far. Other runtimes (Cloudflare, Deno, Bun, etc.) might not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants