Some cleanups #62
Open
Some cleanups #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Feb 10, 2026
mbaldessari
commented
- Remove unused automation_hub_url variable
- Consolidate AAP debug tasks into a single task
- Use local_token_duration_days variable in jwt_check error message
- Quote template variables consistently in agof_overrides.yml.j2
- Fix broken exception handling in activations_to_enable filter
- Remove unused controller_state variable
- Rename vague "Debug" task to "Show AAP hostname"
- Remove unnecessary block wrapper around pre-config fixups
- Consolidate adjacent set_fact tasks in rulebook_activations
- Remove commented-out debug task in resources.yml
- Consolidate AWS user set_fact tasks in aws_check_setup
- Consolidate adjacent debug tasks in teardown.yml
- Use fully qualified collection names for builtin modules in init_env
This variable was defined in preinit_vars.yml but never referenced anywhere in the codebase.
Three separate debug tasks for reporting AAP endpoint, user, and password are combined into one task with a message list.
The error message had "30 days" hardcoded even though the duration is parameterized via local_token_duration_days.
aap_password and aap_hostname were unquoted while other string values in the same file were quoted.
dict.get() never raises exceptions, and IndexError was the wrong type anyway (KeyError would be correct for dicts). The except branch was unreachable, causing every activation to be treated as enabled regardless of its 'enabled' or 'state' values. Replace with explicit key presence check that respects the 'enabled' field value and falls back to checking 'state'.
Defined in configure_aap defaults but never referenced anywhere in the project.
Task name should describe what it shows, not just say "Debug".
A block containing a single task can be replaced with the task directly, moving the when condition onto it.
These two set_fact tasks have no dependency on each other and can be a single task.
aws_user and aws_account are independent facts extracted from the same whoami result and can be set in a single task.
Two separate debug tasks for ec2_vpc_id and ec2_security_group with the same debug_teardown condition are combined into one.
Replace unqualified module names (set_fact, debug, assert, fail, file, include_tasks, template) with their ansible.builtin.* equivalents across all task files in init_env/aws/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.