Implement double config for AdaptiveCrawler#1683
Open
Vaccarini-Lorenzo wants to merge 2 commits intounclecode:mainfrom
Open
Implement double config for AdaptiveCrawler#1683Vaccarini-Lorenzo wants to merge 2 commits intounclecode:mainfrom
Vaccarini-Lorenzo wants to merge 2 commits intounclecode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposed solution to fix Issue #1682
List of files changed and why
File impacted: adaptive_crawler.py
AdaptiveConfig now supports two configs, one for embeddings and one for chat completion API
The configs support provider, base_url and api_token.
How Has This Been Tested?
This is not a breaking change, it just adds an additional config option.
In realtion to Issue #1682 , the new proposed approach would be
Checklist: