add parking vbf and parking hh to 2024 data#114
Open
Conversation
riga
reviewed
Feb 27, 2026
Member
riga
left a comment
riga
left a comment
There was a problem hiding this comment.
Hey, this looks good 👍
Just three small questions out of interest and scrutiny...
| n_files=168 + 197 + 180 + 115 + 150 + 173 + 198 + 237, | ||
| n_events=45_446_278 + 45_471_089 + 45_475_567 + 45_489_416 + 45_438_075 + 45_468_127 + 45_487_079 + 45_469_363, | ||
| aux={ | ||
| "prompt": True, |
Member
There was a problem hiding this comment.
Did you check if all these datasets are really prompt?
(Ok, I guess by definition of parking streams, they should be, but oh well...)
Comment on lines
+765
to
+780
| "/ParkingVBF0/Run2024I-MINIv6NANOv15-v2/NANOAOD", | ||
| "/ParkingVBF1/Run2024I-MINIv6NANOv15-v3/NANOAOD", | ||
| "/ParkingVBF2/Run2024I-MINIv6NANOv15-v3/NANOAOD", | ||
| "/ParkingVBF3/Run2024I-MINIv6NANOv15-v3/NANOAOD", | ||
| "/ParkingVBF4/Run2024I-MINIv6NANOv15-v3/NANOAOD", | ||
| "/ParkingVBF5/Run2024I-MINIv6NANOv15-v2/NANOAOD", | ||
| "/ParkingVBF6/Run2024I-MINIv6NANOv15-v2/NANOAOD", | ||
| "/ParkingVBF7/Run2024I-MINIv6NANOv15-v3/NANOAOD", | ||
| "/ParkingVBF0/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", | ||
| "/ParkingVBF1/Run2024I-MINIv6NANOv15_v2-v3/NANOAOD", | ||
| "/ParkingVBF2/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", | ||
| "/ParkingVBF3/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", | ||
| "/ParkingVBF4/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", | ||
| "/ParkingVBF5/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", | ||
| "/ParkingVBF6/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", | ||
| "/ParkingVBF7/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", |
Member
There was a problem hiding this comment.
Are you sure that both versions per stream (e.g. v2 and v2-v2) are to be used simultaneously?
Comment on lines
+894
to
+895
| "/ParkingHH/Run2024I-MINIv6NANOv15-v3/NANOAOD", | ||
| "/ParkingHH/Run2024I-MINIv6NANOv15_v2-v2/NANOAOD", |
Member
There was a problem hiding this comment.
Same as above: really both of them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.