[Metrics] add support for datadog metric reporting via statsd#23
Open
[Metrics] add support for datadog metric reporting via statsd#23
Conversation
yangy0000
approved these changes
Jan 2, 2025
lifepuzzlefun
approved these changes
Feb 17, 2025
mcruzdev
reviewed
Mar 30, 2025
| StatsDClient statsd = new NonBlockingStatsDClientBuilder() | ||
| .prefix(METRICS_REPORTER_STATSD) | ||
| .hostname(DOCKER_HOST_INTERNAL_ADDRESS) | ||
| .port(8125) |
Contributor
There was a problem hiding this comment.
It should be configurable too, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uForwarder currently only support reporting via M3. This PR add support for datadog integration via statsd. Internally, uForwarder uses tally for M3 reporting and tally also support statsd, which can work with local datadog agent. This PR add a config for choose between
m3orstatsdfor metric reporting.Keeping the old behavior for the M3 path as currently M3 reporting does not set the reporter. Please let me know otherwise.
Test plan: