Draft
Conversation
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
- Coverage 98.62% 97.81% -0.82%
==========================================
Files 35 36 +1
Lines 3337 3427 +90
==========================================
+ Hits 3291 3352 +61
- Misses 39 63 +24
- Partials 7 12 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
**This is just a PoC at this time and not yet ready for review.**
## Details
This change introduces the `fx.Evalute` option,
which allows for dynamic generation of provides, invokes, decorates,
and other evaluates based on the state of existing dependencies.
It addresses one of the more significant remaining pain points
with usage of Fx in large applications and ecosystems:
the ability to programmatically generate parts of the dependency graph.
Concretely, this makes the following possible:
```
fx.Evaluate(func(cfg *Config) fx.Option {
if cfg.Environment == "production" {
return fx.Provide(func(*sql.DB) Repository {
return &sqlRepository{db: db}
}),
} else {
return fx.Provide(func() Repository {
return &memoryRepository{}
})
}
}),
fx.Provide(func(...) *sql.DB { ... }),
```
With fx.Evaluate, the dependency on `*sql.DB` is present in the graph
only in production environments.
In development environments, the dependency connection is absent,
and therefore the database connection is never established.
(Today, attempting to write an Fx module that switches on the backend
like this will result in the SQL connection being established even in
development environments.)
**TODO**
- [ ] Decide whether nilling out the slice is the right approach
for tracking what's been already run
- [ ] fx.Module handling
- [ ] fx.WithLogger handling
- [ ] Testing with every other feature
- [ ] Documentation
Contributor
|
Great idea. |
|
Looking forward to this 👍 |
|
Looking forward to this 👍 |
|
Any updates on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a PoC at this time and not yet ready for review.
Resolves #1132
Details
This change introduces the
fx.Evaluteoption,which allows for dynamic generation of provides, invokes, decorates,
and other evaluates based on the state of existing dependencies.
It addresses one of the more significant remaining pain points
with usage of Fx in large applications and ecosystems:
the ability to programmatically generate parts of the dependency graph.
Concretely, this makes the following possible:
With fx.Evaluate, the dependency on
*sql.DBis present in the graphonly in production environments.
In development environments, the dependency connection is absent,
and therefore the database connection is never established.
(Today, attempting to write an Fx module that switches on the backend
like this will result in the SQL connection being established even in
development environments.)
TODO
for tracking what's been already run