-
Notifications
You must be signed in to change notification settings - Fork 0
KNA-3211/feat: Enabling invoice upload and minor improvements #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
KNA-3211/feat: Enabling invoice upload and minor improvements #22
Conversation
Summary of ChangesHello @SalmanTwo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Two Payment module for PrestaShop by re-enabling and refining the invoice upload functionality, ensuring seamless integration with the Two platform. It also introduces critical improvements to tax and shipping calculation accuracy, addressing previous API validation issues. Furthermore, the company verification process has been made more robust by leveraging organization numbers from customer addresses. A new admin information tab improves merchant usability, and the addition of AI-focused documentation files ('CLAUDE.md', '.ai/*.md') streamlines future development and maintenance. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces new documentation files for AI context and architectural decisions, updates the changelog, and re-enables the invoice upload feature with detailed configuration instructions. It also includes significant improvements to company data resolution during checkout, enhancing the reliability of order intent checks by verifying organization numbers from address fields via the Two API. Tax and shipping calculation logic has been refined for better accuracy and compliance with the Two API, and a new 'Plugin Information' tab has been added to the admin panel for better user guidance. The module version has been updated to 2.3.2.
|
|
||
| ## Quick Rules (see CLAUDE.md for full details) | ||
|
|
||
| 1. **Read CLAUDE.md first** - Contains all development patterns and rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable invoice upload and minor improvements