Update the Methodology to Find delta-t When Resampling a Signal#47
Merged
twmacro merged 1 commit intotwmacro:masterfrom Oct 18, 2025
Merged
Update the Methodology to Find delta-t When Resampling a Signal#47twmacro merged 1 commit intotwmacro:masterfrom
twmacro merged 1 commit intotwmacro:masterfrom
Conversation
twmacro
approved these changes
Oct 18, 2025
Owner
twmacro
left a comment
twmacro
left a comment
There was a problem hiding this comment.
Looks like a nice prudent update! :)
Owner
|
Sorry Ramsey! I didn't see this until today :P Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tim,
This is a minor change that will improve the robustness of the resample function to work with signals that are not perfectly uniform in their time-steps. In the existing code, if
t[1] - t[0]is not representative of the "intended" time step of the signal, the returned time vector will not end att[-1]. I am running into issues with real-world data where the resampled vector can be dramatically different. A 20 second signal can be reduced to a fraction of a second, or vice versa. By updating the code to use the mean of the time steps, these cases end att[-1].