WIP: segcache: use mutex and jemalloc#459
Draft
brayniac wants to merge 13 commits intotwitter:masterfrom
Draft
Conversation
Test using jemalloc
Replaces the queue between the workers and storage thread with a locking implementation.
Contributor
Author
|
For a 9 core configuration on: With a workload: With a backend config: This change brings the redline from 728kqps -> 830kqps |
Changes to the protocol / entrystore layers to allow recycling the buffers which are used to hold key/value responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR, needs performance evaluation
Changes threading model to use shared storage, protected
by a mutex. This removes the overhead of cross-thread
signaling and communication on the request path in favor of
using coarse-locking.
Sets the global allocator to jemalloc for pelikan_segcache_rs