Add ruby 3.4 in build matrix. Test with Rails 7.2 and 8.0#370
Merged
Conversation
Update Gemfile for ruby 3.4 Fix warning: add observer as runtime dependency
Ruby 3.1 Rails <7.2 Update syntax in spec to avoid warning: > test/unit/target_finder_test.rb:89: warning: literal string will be > frozen in the future (run with --debug-frozen-string-literal for more > information)
Contributor
|
Thank you ! 🥳 Are you planning on releasing this soon ? |
Owner
Author
|
Yes, I plan next week. Would you please install from GitHub to test run before I do the major release? Thank you! |
Contributor
|
@tute, just wondering about the release of these changes 😅 I'm pulling from GitHub now, and everything is working great. Tests passed 👌🏽 Thank you for your work on this 🙏🏼 |
Owner
Author
Contributor
|
Awesome! Thank you, @tute. Appreciate it 🙏🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warning: add observer as runtime dependency.
Removes EOL'd Ruby and Rails versions:
Updates syntax in spec to avoid warning:
[fixes #367]