Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage ? 96.42%
=======================================
Files ? 9
Lines ? 560
Branches ? 0
=======================================
Hits ? 540
Misses ? 20
Partials ? 0 ☔ View full report in Codecov by Sentry. |
kamilsi
approved these changes
Mar 22, 2024
Contributor
kamilsi
left a comment
kamilsi
left a comment
There was a problem hiding this comment.
LGTM, let's brek it down to tasks
| block_size = c(3, 6, 9), | ||
| covariates = list( | ||
| sex = list( | ||
| weight = NULL, |
Contributor
There was a problem hiding this comment.
if there is no reason to keep it, then let's drop "weight"
danielinteractive
left a comment
danielinteractive
left a comment
There was a problem hiding this comment.
Just passing by because @kamilsi presented unbiased to our openstatsware team today - but I love that you are using this Rmd with the design/PoC for your package development! We also do this a lot in our packages but so far I have not seen this actively in other places too much. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.