Make TrinoFileSystem closeable #27919
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
user/serafin/closeable-fs
branch
from
b86c7a4 to
6e36001
Compare
wendigo
force-pushed
the
user/serafin/closeable-fs
branch
from
6e36001 to
c92443c
Compare
electrum
reviewed
Jan 15, 2026
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
What is the purpose of this change?
electrum
reviewed
Jan 15, 2026
| @Override | ||
| public void close() | ||
| { | ||
| client.close(); |
Member
There was a problem hiding this comment.
This is broken, as clients are shared across filesystem instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: