feat: add range select variant #277
Open
+465
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
2 times, most recently
from
e06a1d6 to
6c412b5
Compare
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
6c412b5 to
42ece5f
Compare
Contributor
Author
|
Also fixed the "with selected value" story |
lukasbals
reviewed
Feb 11, 2026
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
42ece5f to
c581c62
Compare
lukasbals
reviewed
Feb 11, 2026
Member
lukasbals
left a comment
lukasbals
left a comment
There was a problem hiding this comment.
I'm sorry to be so annoying - but this IMO doesn't fit into the select component. I would make this it's own component to keep the Select cleaner .... if we add properties like rangeFromLabel, ... it really doesn't make sense to have this as a variant of the select. Do you agree?
Comment on lines
139
to
141
| const [value, setValue] = React.useState<string[]>(['', '']); | ||
| const [fromError, setFromError] = React.useState<string>(''); | ||
| const [toError, setToError] = React.useState<string>(''); |
Member
There was a problem hiding this comment.
Suggested change
| const [value, setValue] = React.useState<string[]>(['', '']); | |
| const [fromError, setFromError] = React.useState<string>(''); | |
| const [toError, setToError] = React.useState<string>(''); | |
| const [value, setValue] = useState<string[]>(['', '']); | |
| const [fromError, setFromError] = useState<string>(''); | |
| const [toError, setToError] = useState<string>(''); |
Usually we import useState directly ...
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
c581c62 to
1318c50
Compare
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
1318c50 to
4f78adf
Compare
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
4f78adf to
aeb4cce
Compare
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
aeb4cce to
99f9537
Compare
ClaraTschamon
force-pushed
the
feature/pina-8332-add-range-select
branch
from
99f9537 to
3372e0a
Compare
ClaraTschamon
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Fixed the "with selected value" variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.