Conversation
Session auto-restore only works if the goggles are activated on the page within 5 minutes of data loss. Also, slightly modified lscache to prefix its localStorage keys with 'webxray-' to avoid potential conflicts w/ lscache on the existing page.
This way the user's changes won't get mysteriously applied when they try to hack a different page on the same site.
Since we're saving the user's work before they navigate away and restoring it if they come back, the need for the modal dialog is obviated.
This ensures that even if the localization tests (which load the en locale) don't complete (or aren't run), other tests aren't broken.
|
Once we pull this in and push to production, we should probably follow-up on this hackasaurus google group thread. |
There was a problem hiding this comment.
I feel like this comment should just replace the comment on line 12. Otherwise they contradict each other.
There was a problem hiding this comment.
Oh, good point. Will do that... and actually, we should probably rename this class to something more descriptive than ModalUnloadBlocker, since that's not at all what it's doing anymore. Maybe something like BeforeUnloadManager or something.
|
I think there's a valid use case for wanting to throw away the current hack and start fresh. Maybe providing a key command to start over would be useful, rather than forcing people to wait 5 minutes. |
|
So the way to let them start fresh would be for them to just "undo" until they couldn't undo any more... In Thimble, we provide a little tooltip telling them as much: But we're not currently telling them anything with the goggles... We could probably show a little transparent message, though. |
|
Yep, although I actually found that confusing in Thimble because it makes "Undo" modal in a weird way. It'll undo one little step in the normal case, but everything in the special restoration case. Particularly when I'm new to something, the ability to start fresh is something I want to be easy. But, maybe that's a feature request moreso than a reason to hold up this pull. |
2 participants
@stenington, can you take a look at this?