Feature/custom model editor#426
Feature/custom model editor#426ditschi wants to merge 4 commits intotoniebox-reverse-engineering:developfrom
Conversation
|
Please use the web repo for the web stuff. |
4a44e68 to
0127d1e
Compare
Sure .. Second PR will be created for submodule changes |
…anagement - Backend: tonies.custom.json save API with validation and backups - Backend: custom_img root support for image workflows - Frontend: Full editor for custom models (add, edit, delete) - Frontend: Image picker and file browser integration - Remove built web assets (now built from teddycloud_web submodule)
0127d1e to
95b2482
Compare
|
Please also remove the compiled web changes (contrib www) |
|
This would solve the following issues: |
- Remove custom_editor_preview setting (editor always active) - Ignore contrib/data/www/ (compiled web assets) - Update teddycloud_web submodule (v0.7.0, PR feedback) Made-with: Cursor
removed and added to .gitignore. |
c738c7d to
68eef21
Compare
- Added ca-certificates to the list of packages installed in the build environment.
68eef21 to
d796621
Compare
.gitignore
Outdated
| /report | ||
| /bin | ||
| /stockaudio | ||
| contrib/data/www/ |
There was a problem hiding this comment.
Please don't add it to the .gitignore
It should be in the repo, but not committed manually. The pipeline does.
Also don't commit the submodule changes of _web into this repo
There was a problem hiding this comment.
Removed contrib/data/www/ from .gitignore.
I’d like to clarify the workflow so I can document it for contributors. I assumed I had to update the teddycloud PR with the teddycloud_web merge commit (after PR #283 is merged) before merging the main PR. Your comment suggests I should not commit submodule changes in this PR.
Questions:
Is the intended flow: merge both PRs separately (web first, then backend), then a maintainer updates the submodule pointer?
I couldn’t find this workflow documented in the README or elsewhere. Would it be okay if I add a short section (e.g. in README or a new CONTRIBUTING.md) for future contributors?
Thanks for the clarification.
There was a problem hiding this comment.
Have a look into the actions. As far as I know it’s a mix of manual execution and automation:
https://github.com/toniebox-reverse-engineering/teddycloud/actions/workflows/build_commit_web.yml
and then a commit into develop starts automatically https://github.com/toniebox-reverse-engineering/teddycloud/actions/workflows/publish_docker_matrix_all.yml which generates the docker images.
This Adds
I also removed built web assets from teddycloud_web submodule -- i assume that was added by accident?!)
REQUIRED BY: Web changes from toniebox-reverse-engineering/teddycloud_web#283
Preview -- what will these backend changes make available in web
Custom Tonies Editor: Editor for managing custom tonie models
Settings: Enable/Disable Editor -- (changes menu entry from

WIP: Add ModeltoManage custom modelsCustom tonies editor

Manage custom modelsImage Manager:
Shared UI for selecting and managing images in TeddyStudio and Custom Tonies Editor
Image Editor::Default Images

Image Editor::Upload and manage Custom Images -- also available in Tonie Studio
