Skip to content

Feature/custom model editor#426

Draft
ditschi wants to merge 4 commits intotoniebox-reverse-engineering:developfrom
ditschi:feature/custom-model-editor
Draft

Feature/custom model editor#426
ditschi wants to merge 4 commits intotoniebox-reverse-engineering:developfrom
ditschi:feature/custom-model-editor

Conversation

@ditschi
Copy link

@ditschi ditschi commented Mar 9, 2026

This Adds

  • tonies.custom.json save API with validation and backups
  • custom_img root support for image workflows

I also removed built web assets from teddycloud_web submodule -- i assume that was added by accident?!)

REQUIRED BY: Web changes from toniebox-reverse-engineering/teddycloud_web#283

Preview -- what will these backend changes make available in web

Custom Tonies Editor: Editor for managing custom tonie models

Settings: Enable/Disable Editor -- (changes menu entry from WIP: Add Model to Manage custom models
grafik

Custom tonies editor Manage custom models
grafik

Image Manager:

Shared UI for selecting and managing images in TeddyStudio and Custom Tonies Editor

Image Editor::Default Images
grafik

Image Editor::Upload and manage Custom Images -- also available in Tonie Studio
grafik

@SciLor
Copy link
Contributor

SciLor commented Mar 9, 2026

Please use the web repo for the web stuff.

@ditschi ditschi force-pushed the feature/custom-model-editor branch 2 times, most recently from 4a44e68 to 0127d1e Compare March 9, 2026 22:14
@ditschi
Copy link
Author

ditschi commented Mar 9, 2026

Please use the web repo for the web stuff

Sure .. Second PR will be created for submodule changes

…anagement

- Backend: tonies.custom.json save API with validation and backups
- Backend: custom_img root support for image workflows
- Frontend: Full editor for custom models (add, edit, delete)
- Frontend: Image picker and file browser integration
- Remove built web assets (now built from teddycloud_web submodule)
@ditschi ditschi force-pushed the feature/custom-model-editor branch from 0127d1e to 95b2482 Compare March 9, 2026 22:33
@SciLor
Copy link
Contributor

SciLor commented Mar 10, 2026

Please also remove the compiled web changes (contrib www)
This will be done later by the pipeline.

@henryk86
Copy link
Collaborator

- Remove custom_editor_preview setting (editor always active)
- Ignore contrib/data/www/ (compiled web assets)
- Update teddycloud_web submodule (v0.7.0, PR feedback)

Made-with: Cursor
@ditschi
Copy link
Author

ditschi commented Mar 11, 2026

Please also remove the compiled web changes (contrib www) This will be done later by the pipeline.

removed and added to .gitignore.

@ditschi ditschi force-pushed the feature/custom-model-editor branch from c738c7d to 68eef21 Compare March 11, 2026 00:22
- Added ca-certificates to the list of packages installed in the build environment.
@ditschi ditschi force-pushed the feature/custom-model-editor branch from 68eef21 to d796621 Compare March 11, 2026 00:25
.gitignore Outdated
/report
/bin
/stockaudio
contrib/data/www/
Copy link
Contributor

@SciLor SciLor Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add it to the .gitignore
It should be in the repo, but not committed manually. The pipeline does.

Also don't commit the submodule changes of _web into this repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed contrib/data/www/ from .gitignore.

I’d like to clarify the workflow so I can document it for contributors. I assumed I had to update the teddycloud PR with the teddycloud_web merge commit (after PR #283 is merged) before merging the main PR. Your comment suggests I should not commit submodule changes in this PR.

Questions:

Is the intended flow: merge both PRs separately (web first, then backend), then a maintainer updates the submodule pointer?
I couldn’t find this workflow documented in the README or elsewhere. Would it be okay if I add a short section (e.g. in README or a new CONTRIBUTING.md) for future contributors?
Thanks for the clarification.

Copy link
Collaborator

@henryk86 henryk86 Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look into the actions. As far as I know it’s a mix of manual execution and automation:

https://github.com/toniebox-reverse-engineering/teddycloud/actions/workflows/build_commit_web.yml

and then a commit into develop starts automatically https://github.com/toniebox-reverse-engineering/teddycloud/actions/workflows/publish_docker_matrix_all.yml which generates the docker images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants