fix: split stake in 2 when not elected / ValidatorList in testnet#260
Open
redref wants to merge 2 commits intoton-blockchain:mytonctrl2from
Open
fix: split stake in 2 when not elected / ValidatorList in testnet#260redref wants to merge 2 commits intoton-blockchain:mytonctrl2from
redref wants to merge 2 commits intoton-blockchain:mytonctrl2from
Conversation
Bassota
approved these changes
May 19, 2024
Author
|
Not tested in mainnet yes, but if you can confirm this a right solution, I could. |
Collaborator
|
Can you describe a bug that you're trying to fix? |
Author
Sure. FTR, this was in testnet.
This check temporary key is in active period and we are not an active validator to check validator was not elected, which avoids a different behavior. We could argue it gives better chance to be elected in second iteration, but in my POV, if we want to solve this issue, it would be best solved otherwise. For testnet, I had to fix GetValidatorsList() which does not work properly (checkloadall returns nothing or raise an error, but I think that's expected). |
Saichitthae
approved these changes
Jun 7, 2024
Author
|
Any news ? |
Saichitthae
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.