Open
Conversation
Author
|
as related work there is also a std lib proposal to add a |
Member
|
I don't really get why we should add this. It seems pretty niche. |
Author
|
I find the method useful for decoding data from a let mut key_buf = [0u8; 32];
buf.copy_to_slice(&mut key);
let key = key_buf;compared to let key: [u8; 32] = buf.get_array();this can also be achieved with an extension traitpub trait BufExtArray: Buf {
fn get_array<const N: usize>(&mut self) -> [u8; N] {
self.try_get_array()
.unwrap_or_else(|error| panic_advance(&error))
}
fn try_get_array<const N: usize>(&mut self) -> Result<[u8; N], bytes::TryGetError> {
if self.remaining() < N {
return Err(bytes::TryGetError {
requested: N,
available: self.remaining(),
});
}
let ret = self.chunk().first_chunk::<N>().copied();
if let Some(ret) = ret {
// if the direct get was possible, advance and return
self.advance(N);
Ok(ret)
} else {
// if not we copy the bytes in a temp buffer
let mut buf = [0; N];
self.copy_to_slice(&mut buf); // (do the advance)
Ok(buf)
}
}
}
impl<B: Buf + ?Sized> BufExtArray for B {}so if you find it to niche for including please close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would increase the MSRV to 1.51 since it uses const generics!
I am not sure on the MSRV policy of bytes, so if this is a problem we can just close this PR
Added Methods
Buf::try_get_arrayis a copy of the old implementation of
buf_try_get_implBuf::get_arraysimply callstry_get_arrayandpanic_advanceon errorthe second commit changes the implementation of the
get_xmethods to usetry_get_arraythis would also enable
Bufimplementors to optimise (like #622) theget_xmethods by overridingtry_get_array