Open
Conversation
Updated `commander` version Changed to new `Command` module Use `opts` instead of `program` Slight reorganization in `create` due to ordering. Add test for multiple envs
|
Thanks. I have been waiting for this feature my whole life |
Collaborator
|
Thanks for the work @Tordek. Unfortunately it looks like there are many changes in here which are unrelated to |
Author
|
It's not really possible. Commander needs to be updated to support the
I could remove the |
Collaborator
|
Ah, thanks for the clarification. Yes I can see how this is related now. In that case, I would recommend doing two prs:
That should be easy enough to just remove the variadic from the |
Author
|
Fair enough, I'll do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotenvsupports passing multiple.envfiles as an array, but the old version ofcommanderdoes not support variadic parameters.