Investigate Mettle timeout on premerge and postmerge tests#340
Open
olha-ctrl wants to merge 11 commits intothought-machine:masterfrom
Open
Investigate Mettle timeout on premerge and postmerge tests#340olha-ctrl wants to merge 11 commits intothought-machine:masterfrom
olha-ctrl wants to merge 11 commits intothought-machine:masterfrom
Conversation
* Add logProcOnTimeout() * Bump version
olha-ctrl
changed the title
scyyx5
reviewed
Mar 6, 2026
toastwaffle
requested changes
Mar 6, 2026
Hamishpk
approved these changes
Mar 9, 2026
toastwaffle
reviewed
Mar 9, 2026
mettle/worker/worker.go
Outdated
| ) | ||
| } | ||
| childrenSummary = strings.Join(items, " | ") | ||
| break |
Contributor
There was a problem hiding this comment.
Doesn't this mean we now stop exploring deeply if we find multiple children? that also seems impractical; shouldn't we be outputting the whole tree?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logProcChain() to print child processes that keep worker in a waiting state:
Logs from kibana indicates that some pipes are still
open pipe:[850045] 2 -> pipe:[850046], so want to find out what they are.time="18:57:33.007" level=debug msg="Deadline exceeded: /proc snapshot" cmdline="/usr/local/bin/tm_sandbox bash --noprofile --norc -u -o pipefail -c export TMP_DIR=\"pwd\" TEST_DIR=\"pwd\" && export TEST=\"$TEST_DIR/notifications_service_sat\" && $TEST -kafka_provider=redpanda -db_provider=psql 2>&1 | tee $TMP_DIR/test.results && $TOOLS_GO tool covdata textfmt -i=. -o=$COVERAGE_FILE" fds="[0 -> /dev/null 1 -> pipe:[850045] 2 -> pipe:[850046]]" hash=9bbb0b015a5b9fcdbb53256e49444e65408bdac19921c68995c8f0d8a6d48314 pid=24877 wchan=do_wait