Skip to content

Improve runCommand timeout diagnostics (process snapshot + output summary)#338

Merged
olha-ctrl merged 2 commits intothought-machine:masterfrom
olha-ctrl:log_hanging_processtree
Feb 19, 2026
Merged

Improve runCommand timeout diagnostics (process snapshot + output summary)#338
olha-ctrl merged 2 commits intothought-machine:masterfrom
olha-ctrl:log_hanging_processtree

Conversation

@olha-ctrl
Copy link
Contributor

  • Switched to Start() + Wait() for better timeout observability, it help to capture process exactly when ctx.Done() fires; previous catch on ContextDeadline is too late.
  • Set cmd.SysProcAttr.Setpgid = true in execute to avoid overriding in in the runCommand
  • Add readable output summary on timeout to get better understanding of last this process was doing (just last line to avoid chunky logs)
  • Added: etime (how long the process has been running),wchan (Wait channel) for processTree to log

@olha-ctrl olha-ctrl merged commit c32cb2e into thought-machine:master Feb 19, 2026
2 of 3 checks passed
olha-ctrl added a commit to olha-ctrl/please-servers that referenced this pull request Feb 26, 2026
…mary) (thought-machine#338)

* Improve runCommand timeout diagnostics (process snapshot + output summary)
olha-ctrl added a commit to olha-ctrl/please-servers that referenced this pull request Feb 26, 2026
…mary) (thought-machine#338)

* Improve runCommand timeout diagnostics (process snapshot + output summary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants