Conversation
|
Can one of the admins verify this patch?
|
|
test this please |
niranjanhyti
force-pushed
the
for-tac5572
branch
from
7887d72 to
a2ab21f
Compare
|
Link to the kernel side PR thesofproject/linux#5675 |
| @@ -55,6 +55,14 @@ PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-rt712-l0-4ch.bin,\ | |||
| HDMI1_ID=5,HDMI2_ID=6,HDMI3_ID=7,DMIC0_ENHANCED_CAPTURE=true,\ | |||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default" | |||
|
|
|||
| "cavs-sdw\;sof-mtl-tac5572-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\ | |||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_AMP_FEEDBACK_STREAM=Capture-SmartAmp,\ | |||
There was a problem hiding this comment.
SDW_AMP_FEEDBACK_STREAM is not necessary while SDW_AMP_FEEDBACK=false.
There was a problem hiding this comment.
In fact, I can't find 'SDW_AMP_FEEDBACK_STREAM' in the existing code. Did you define it somewhere?
There was a problem hiding this comment.
This is a miss from my side to remove this. I had added for some debugging purpose.
|
|
||
| "cavs-sdw\;sof-mtl-tac5672-2ch\;PLATFORM=mtl,\ | ||
| NUM_SDW_AMP_LINKS=1,SDW_AMP_FEEDBACK=true,SDW_SPK_STREAM=Playback-SmartAmp,\ | ||
| SDW_AMP_FEEDBACK_STREAM=Capture-SmartAmp,SDW_SPK_IN_STREAM=SDW0-Capture-SmartAmp,\ |
There was a problem hiding this comment.
Please set SDW_SPK_IN_STREAM=Capture-SmartAmp, otherwise, the topology can be used only when the codec is on SDW link0. Also, please double check if SDW_AMP_FEEDBACK_STREAM is used. I can't find it in the current code.
There was a problem hiding this comment.
@bardliao
I can see the "Amp feedback" device for the capture, along with "Jack In" and "Microphone". But the "Jack In" seems to be broken after adding the "Amp feedback". While capturing it throws the following error.
[ 70.258722] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to create module alh-copier.Capture-SimpleJack.0
[ 70.258737] snd_sof:sof_ipc4_log_header: sof-audio-pci-intel-mtl 0000:00:1f.3: ipc tx : 0x12000000|0x0
[ 70.259981] snd_sof:sof_ipc4_log_header: sof-audio-pci-intel-mtl 0000:00:1f.3: ipc tx reply: 0x32000000|0x0
[ 70.260133] snd_sof:sof_ipc4_log_header: sof-audio-pci-intel-mtl 0000:00:1f.3: ipc tx done : 0x12000000|0x0
[ 70.260143] snd_sof:sof_widget_free_unlocked: sof-audio-pci-intel-mtl 0000:00:1f.3: widget pipeline.11 freed
[ 70.260147] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to set up connected widgets
[ 70.260158] sof-audio-pci-intel-mtl 0000:00:1f.3: failed widget list set up for pcm 1 dir 1
[ 70.260162] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC error (-22): at snd_soc_pcm_component_prepare() on 0000:00:1f.3```
Kernel logs are attached:
[02_runtime_hp_capture_error.txt](https://github.com/user-attachments/files/25733619/02_runtime_hp_capture_error.txt)
[01_kernel_logs_boottime.txt](https://github.com/user-attachments/files/25733620/01_kernel_logs_boottime.txt)
This commit addes the cmake file changes to generate topology file to support TI's codec chip tac5572 Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
This commit addes the cmake file changes to generate topology file to support TI's amplifier tas2883 Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
Add cmake configuration to generate topology file for TI TAC5672 codec with IV sense feedback enabled (SDW_AMP_FEEDBACK=true). Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
niranjanhyti
force-pushed
the
for-tac5572
branch
from
a2ab21f to
1a29525
Compare
5 participants
This is the initial commit to support family of devices tac5xx2 with SoundWire interface.
This PR includes the changes for .cmake files to create the tplg files.