Replace old graphics api with Porthole#823
Draft
ouz-a wants to merge 16 commits intotheseus-os:theseus_mainfrom
Draft
Replace old graphics api with Porthole#823ouz-a wants to merge 16 commits intotheseus-os:theseus_mainfrom
ouz-a wants to merge 16 commits intotheseus-os:theseus_mainfrom
Conversation
kevinaboos
requested changes
Jan 31, 2023
Member
kevinaboos
left a comment
kevinaboos
left a comment
There was a problem hiding this comment.
forgot to submit this review, sorry. Some things may have already been addressed.
ouz-a
force-pushed
the
port-1
branch
3 times, most recently
from
56af037 to
288b523
Compare
* Add framebuffer trait to abstract framebuffers * Reimplement much simpler version of `FramebufferRowIter` * Use "Framebuffer", not "FrameBuffer" * Add tons of notes, search for "@Ouz"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Longer comment will be here
Adds on top of what's built on #722, replaces entire graphics api with Porthole
Tasks: