Add support for Nix/NixOS#1101
Draft
JustAnotherCodemonkey wants to merge 4 commits intotheseus-os:theseus_mainfrom
Draft
Add support for Nix/NixOS#1101JustAnotherCodemonkey wants to merge 4 commits intotheseus-os:theseus_mainfrom
JustAnotherCodemonkey wants to merge 4 commits intotheseus-os:theseus_mainfrom
Conversation
There are still some major todos, as can be seen in the NIX.md.
…tially-featured build host.)
Author
|
This is quickly becoming an issue. I've been relying on the Makefile, but for supporting non-x86_64 users and cross-compilation, it seems I will need to write a derivation (or maybe even just a flake) that re-creates the steps of the Makefile. This is really bad news to me, as the derivation/flake will need to be updated every time there is a change in the build process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The build instructions in the README are not only not idiomatic to those who use Nix as their package manager, but do not work on NixOS itself. This PR addresses this by not only modifying the README for Nix/NixOS users but providing powerful utilities for Nix users, specifically, a Nix shell (shell.nix), a (maybe) Nix derivation (default.nix), and a (maybe) Nix flake (flake.nix). There may also be small things to tie up or patch as well before the PR is considered fully polished.
State of the PR
The PR is technically ready to merge now and it would add basic functionality with few/no loose ends. However, there are more features planned that have yet to be implemented. Some of them are considered "important" as they patch notable missing functionality for being able to create a Nix development shell (such as the ability to use the Limine bootloader, or the ability to build Theseus for other architectures). Others are considered "nice-to-have" and many of these will likely not fully make their way into this PR, and it may simply end up being Nix shells, with the other parts possibly coming in another PR. The desired features and their state of completion are as follows:
Important Features
"Would be Nice" Features
$out/iso/or$out/img/?)Considerations
Important Questions to be Answered